Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !16379
Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Merged
Created Jan 11, 2018 by Eric Eastwood@MadLittleModsContributor10 of 11 tasks completed10/11 tasks
  • Review changes

  • Download
  • Email patches
  • Plain diff

Add feature highlight blue dot to GKE "Clusters" sidebar item

  • Overview 73
  • Commits 1
  • Pipelines 18
  • Changes 20

What does this MR do?

EE MR, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4311

  • Restores feature highlight blue dot code from https://gitlab.com/gitlab-org/gitlab-ce/issues/36760 which was reverted in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14373

Are there points in the code the reviewer needs to double check?

BE MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16735

Remove the dismissal entry from the database

Here are some instructions on how to remove the persistent dismissal from the database, https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16735#example-usage: bundle exec rails c -> Callout.find_by(user: User.find_by(username: 'root'), feature_name: 'gke_cluster_integration').update(dismissed_state: false) UserCallout.find_by(user: User.find_by(username: 'root'), feature_name: UserCallout.feature_names['gke_cluster_integration']).destroy. Because of a BE bug, you need to be an explicit admin of the project (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16735/diffs#note_56649940).


Previous blue dot feature highlight MRs

  • https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13515
  • https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2875

Todo

  • Perhaps also port over https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14165
  • Wait for ajax endpoint for persistent dismissal

Why was this MR needed?

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered

What are the relevant issue numbers?

Closes #41672 (closed)

Edited Feb 05, 2018 by Eric Eastwood
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 41672-emphasize-gke-cluster-to-new-users