Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !14563

Clear merge requests counter cache after merge

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sean McGivern requested to merge fix-mr-sidebar-counter-after-merge into master Sep 28, 2017
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 3

What does this MR do?

Refresh the MR counter cache after merging an MR.

Are there points in the code the reviewer needs to double check?

Don't think so.

Why was this MR needed?

We did this on every MR state change event except a merge, so if the last change to an MR's state was a merge, the counter would be wrong.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/3573 and https://gitlab.com/gitlab-org/gitlab-ce/issues/38344.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-mr-sidebar-counter-after-merge