Fix gitaly ref encoding bugs

What does this MR do?

Adds missing encoding coercion calls on Gitaly ref responses.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

We were injecting ASCII-8BIT strings into GitLab, that doesn't work. It has to be UTF-8.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/34156

lib/gitlab/gitaly_client/ref.rb

@@ -19,13 +19,13 @@ def default_branch_name
       def branch_names
         request = Gitaly::FindAllBranchNamesRequest.new(repository: @gitaly_repo)
         response = GitalyClient.call(@storage, :ref, :find_all_branch_names, request)
-        response.flat_map { |message| message.names.map { |name| Gitlab::Git.branch_name(name) } }
+        consume_refs_response(response) { |name| Gitlab::Git.branch_name(name) }
       end
 
       def tag_names
         request = Gitaly::FindAllTagNamesRequest.new(repository: @gitaly_repo)
         response = GitalyClient.call(@storage, :ref, :find_all_tag_names, request)
-        response.flat_map { |message| message.names.map { |name| Gitlab::Git.tag_name(name) } }
+        consume_refs_response(response) { |name| Gitlab::Git.tag_name(name) }
       end
 
       def find_ref_name(commit_id, ref_prefix)
@@ -54,6 +54,10 @@ def local_branches(sort_by: nil)
 
       private
 
+      def consume_refs_response(response)
+        response.flat_map { |message| message.names.map { |name| yield(name) } }
+      end
+
       def sort_by_param(sort_by)
         enum_value = Gitaly::FindLocalBranchesRequest::SortBy.resolve(sort_by.upcase.to_sym)
         raise ArgumentError, "Invalid sort_by key `#{sort_by}`" unless enum_value