Skip to content
GitLab Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !10383

Implement ability to update deploy keys

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alexander Randa requested to merge randaalex/gitlab-ce:3191-deploy-keys-update into master Mar 31, 2017
  • Overview 132
  • Commits 1
  • Pipelines 25
  • Changes 27

What does this MR do?

Implement ability to update deploy keys

Are there points in the code the reviewer needs to double check?

I suppose so if deploy_key added via admin panel, user should not have ability to rename it (because it will be affected to all users) and Edit button not available for public keys (but admins can rename them via admin panel).

And I didn't update documentation.

Screenshots (if relevant)

screen1 screen2

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • [ ]~~ Documentation created/updated~~
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes #3191 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 3191-deploy-keys-update