Skip to content
Snippets Groups Projects

Resolve "Banzai::Filter::MergeRequestReferenceFilter has three N+1 query problems"

All threads resolved!
Files
4
@@ -11,8 +11,8 @@ def self.object_class
MergeRequest
end
def find_object(project, id)
project.merge_requests.find_by(iid: id)
def find_object(project, iid)
merge_requests_per_project[project][iid]
end
def url_for_object(mr, project)
@@ -21,6 +21,31 @@ def url_for_object(mr, project)
only_path: context[:only_path])
end
def project_from_ref(ref)
projects_per_reference[ref || current_project_path]
end
# Returns a Hash containing the merge_requests per Project instance.
def merge_requests_per_project
@merge_requests_per_project ||= begin
hash = Hash.new { |h, k| h[k] = {} }
projects_per_reference.each do |path, project|
merge_request_ids = references_per_project[path]
merge_requests = project.merge_requests
.where(iid: merge_request_ids.to_a)
.includes(target_project: :namespace)
merge_requests.each do |merge_request|
hash[project][merge_request.iid.to_i] = merge_request
end
end
hash
end
end
def object_link_text_extras(object, matches)
extras = super
Loading