Skip to content
Snippets Groups Projects

Fixed up issue boards JS specs

Merged Fixed up issue boards JS specs
issue-boards-test-fix into master
All threads resolved!
Merged Phil Hughes requested to merge issue-boards-test-fix into master
All threads resolved!

What does this MR do?

The objects were passed into the method in the wrong order so would eventually cause a timeout which didn't get caught by the CI. To make sure it does get caught, i've changed the IDs to be random so it would of failed straight away.

What are the relevant issue numbers?

Closes #29329 (closed)

Merge request reports

Pipeline #7263844 passed

Stage: prepare
Stage: test
Stage: post-test

Pipeline passed for 88280aa6 on issue-boards-test-fix

Test coverage 69.38% (23.96%) from 2 jobs

Merged by avatar (Mar 1, 2025 5:33am UTC)

Loading

Pipeline #7266420 failed

Stage: prepare
Stage: test
Stage: post-test
Stage: pages

Pipeline failed for 7181b345 on master

Test coverage 45.32% (23.96%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Filipa Lacerda
    Filipa Lacerda @filipa ·
    Contributor

    @iamphill just a comment

  • Filipa Lacerda assigned to @iamphill

    assigned to @iamphill

  • Phil Hughes added 1 commit

    added 1 commit

    • 88280aa6 - Fixed up issue boards JS specs

    Compare with previous version

  • Phil Hughes resolved all discussions

    resolved all discussions

  • Phil Hughes assigned to @filipa

    assigned to @filipa

  • Filipa Lacerda approved this merge request

    approved this merge request

  • Filipa Lacerda enabled an automatic merge when the pipeline for 88280aa6 succeeds

    enabled an automatic merge when the pipeline for 88280aa6 succeeds

  • Filipa Lacerda changed milestone to %9.1

    changed milestone to %9.1

  • Filipa Lacerda
    Filipa Lacerda @filipa ·
    Contributor

    @iamphill I added %9.1 milestone, feel free to change it :muscle:

  • Phil Hughes
    Phil Hughes @iamphill ·
    Author Developer

    @filipa its only spec so 9.1 is fine :thumbsup:

  • Filipa Lacerda merged

    merged

  • Filipa Lacerda mentioned in commit 7181b345

    mentioned in commit 7181b345

    • Please register or sign in to reply