From d2ab3c8eca4ddf6b542eb44b82c7933280cecc8c Mon Sep 17 00:00:00 2001
From: Kushal Pandya <kushal@gitlab.com>
Date: Thu, 23 Mar 2017 16:50:34 +0530
Subject: [PATCH 1/3] Add tooltip and a11y label for profile cover buttons
---
app/views/users/show.html.haml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/views/users/show.html.haml b/app/views/users/show.html.haml
index dc9a3b0d0df6..34b694b15b1e 100644
--- a/app/views/users/show.html.haml
+++ b/app/views/users/show.html.haml
@@ -13,7 +13,7 @@
.cover-block.user-cover-block
.cover-controls
- if @user == current_user
- = link_to profile_path, class: 'btn btn-gray' do
+ = link_to profile_path, class: 'btn btn-gray has-tooltip', title: 'Edit profile', 'aria-label': 'Edit profile' do
= icon('pencil')
- elsif current_user
- if @user.abuse_report
@@ -24,7 +24,7 @@
= link_to new_abuse_report_path(user_id: @user.id, ref_url: request.referrer), class: 'btn btn-gray',
title: 'Report abuse', data: { toggle: 'tooltip', placement: 'bottom', container: 'body' } do
= icon('exclamation-circle')
- = link_to user_path(@user, rss_url_options), class: 'btn btn-gray' do
+ = link_to user_path(@user, rss_url_options), class: 'btn btn-gray has-tooltip', title: 'Subscribe', 'aria-label': 'Subscribe' do
= icon('rss')
- if current_user && current_user.admin?
= link_to [:admin, @user], class: 'btn btn-gray', title: 'View user in admin area',
--
GitLab
From 1f0f280f0b164ff266c5713946f6b2092edaa58e Mon Sep 17 00:00:00 2001
From: Kushal Pandya <kushal@gitlab.com>
Date: Thu, 23 Mar 2017 16:51:01 +0530
Subject: [PATCH 2/3] Add changelog entry
---
changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml | 4 ++++
1 file changed, 4 insertions(+)
create mode 100644 changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml
diff --git a/changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml b/changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml
new file mode 100644
index 000000000000..dfccdbde84b6
--- /dev/null
+++ b/changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml
@@ -0,0 +1,4 @@
+---
+title: Add tooltip and accessibility for profile cover buttons
+merge_request:
+author:
--
GitLab
From 6b328ea0b7429311e68f3dc20af68d6d66036fc9 Mon Sep 17 00:00:00 2001
From: Kushal Pandya <kushal@gitlab.com>
Date: Thu, 23 Mar 2017 17:03:46 +0530
Subject: [PATCH 3/3] [ci skip] Add MR number
---
changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml b/changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml
index dfccdbde84b6..754d471c7d71 100644
--- a/changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml
+++ b/changelogs/unreleased/29930-fix-profile-cover-button-a11y.yml
@@ -1,4 +1,4 @@
---
title: Add tooltip and accessibility for profile cover buttons
-merge_request:
+merge_request: 10182
author:
--
GitLab