MR diffs and discussions fail to load when diffs contain submodules that are not added to .gitmodules
https://sentry.gitlab.net/gitlab/gitlabcom/issues/867788/
NoMethodError: undefined method `[]' for nil:NilClass
gitlab/submodule_links.rb:12:in `for'
submodule_url = submodule_url_for(sha)[submodule.path]
diff_file_base_entity.rb:97:in `block in memoized_submodule_links'
options[:submodule_links].for(diff_file.blob, diff_file.content_sha)
gitlab/utils/strong_memoize.rb:30:in `strong_memoize'
instance_variable_set(ivar(name), yield)
diff_file_base_entity.rb:95:in `memoized_submodule_links'
strong_memoize(:submodule_links) do
diff_file_base_entity.rb:15:in `block in <class:DiffFileBaseEntity>'
memoized_submodule_links(diff_file, options).first
...
(161 additional frame(s) were not displayed)
NoMethodError: undefined method `[]' for nil:NilClass
/cc @grzesiek @smcgivern
Edited by Douwe Maan