Follow up: Refactor Toolbar

Followup to discussion in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28736#note_175485380.

Refactor the toolbar script to take advantage of modules (now that we can!) and conform to our linter.