Make `repositories.storages.path` setting not mandatory for Gitaly client
In GitalyClient::StorageSettings
, we make path
key mandatory in repositories.storages
configuration. Without this key, DB migration will fail during first gitlab-ctl reconfigure
.
However, for scenarios where Gitaly is run externally on a different server, this path
key does nothing for the GitLab (client) server. And we do not mention it in the docs either, thus making the docs incorrect. (git_data_dirs
gets converted as repositories.storages
in omnibus-gitlab).
If detecting external Gitaly scenarios and removing this mandatory requirement is technically complex, can we modify the docs to mention that users need to provide path
variable also in git_data_dirs
(which is not an ideal solution since that information is not needed there, but we are asking them to put it just for our sake) ?
@jacobvosmaer-gitlab WDYT?