Skip to content

Find Files Links Not URL Encoded

Summary

Links in the list of files from the find file feature are not url safe

Steps to reproduce

Have a file with a # in the name and search for it using find files. It will show up but the link will have the # breaking the url. Replacing the # with %23 causes the link to work as expected.

Example Project

Example project https://gitlab.com/casey.m.timm/findfilebugexample/

Bugged page https://gitlab.com/casey.m.timm/findfilebugexample/find_file/master

Bugged link https://gitlab.com/casey.m.timm/findfilebugexample/blob/master/test#.txt

Expected link https://gitlab.com/casey.m.timm/findfilebugexample/blob/master/test%23.txt

What is the current bug behavior?

Files with # in their name in find file lead to a 404

What is the expected correct behavior?

Links should lead to a page about the file

Relevant logs and/or screenshots

N/A

Output of checks

N/A

Results of GitLab environment info

N/A

Results of GitLab application Check

N/A

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Edited by Rémy Coutable