Underscore not visible on gitlab pages domain verification, CNAME input

Summary

The underscore is not obvious (see screenshot below) I has not understanding why my domains could not be verified, I had forgot to copy the _ underscore and visual verification did not help ..

The text is _gitlab-pages-verification-code. [...]

Steps to reproduce

• Add a domain to gitlab pages
• See the CNAME verification input

What is the current bug behavior?

The underscore is hidden by the style of the input

What is the expected correct behavior?

See the _ at the start of the input

Relevant logs and/or screenshots

Also related to https://gitlab.com/gitlab-org/gitlab-ce/issues/40241.

/cc @jlenny because ~Release

/cc @nick.thomas because ~pages

changed milestone to %Backlog

added Category:Pages [deprecated] Accepting merge requests backend default-priority default-severity devopsrelease [DEPRECATED] priority3 severity3 typebug + 1 deleted label

@gtsiolis this is to do with the domain verification, rather than a bad namespace - it's actually required that the created verification domain be _gitlab-pages-verification-code....

Interestingly, this is visible to me (firefox 60.x, debian linux):

So I guess this might be a display bug between different browsers? Can you say what you're using @williamdes ?

cc @leipert due to 78ff68a2 , which is the likely cause of change here.

(Note that these codes are all public, what matters is where they are published, rather than the contents themselves)

@nick.thomas I am using (reproduced on)

• Vivaldi 2.4.1488.38 (Stable channel) (64 bits)
• Google Chrome Version 73.0.3683.103 (Build officiel) (64 bits)
• Opera 60.0.3255.27

@williamdes Interesting. Which platform are you on? I can see it on the same Chrome version on OSX.

@leipert I am using Ubuntu

Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.2 LTS
Release:	18.04
Codename:	bionic

The bug does not exist on Google Chrome (Android) and does not exist on Brave (Android)

I can recreate this in Chrome (it works on Firefox) on elementary OS 0.4.1 Loki which is built on Ubuntu 16.

FYI @pslaughter is my professional account .

FYI @souldzin is my personal account .

This is very similar to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25910, where text was clipped under certain environments. We should double check here that we're handling line heights correctly. It sounds like the environments we develop on are more graceful than others.

mentioned in issue gitlab-pages#238 (closed)

added 1 deleted label

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue