Merge Request comments have stopped appearing for the whole project

For example, consider the private repository https://gitlab.com/musedev/muse/merge_requests/192

Comments are not appearing even though some MRs have 10 notes attached. These comments were made by a bot and are likely somewhat long (thousands of bytes)... but I wouldn't know for sure because I can't see them.

I also experienced this issue with gitlab-ee but was unable to provide a reproduceable test to the team, hopefully now being on gitlab.com makes that unnecessary.

mentioned in issue #61160 (closed)

Thanks for reporting this @tommd ! Looks like the above mentioned one is a private repo. Would it be possible to grant access or provide other ways in which we could see the issue?

added Plan [DEPRECATED] devopsplan frontend merge requests labels

/cc @donaldcook

Who would be the right person to grant? @donaldcook or someone else?

Can you please grant access to both and me and @at.ramya?

Access granted.

Please see, for example, issue 192 which has 10 comments but none will display and instead we are greeted with "Something went wrong when fetching comments. Please try again.".

This is the Sentry issue: https://sentry.gitlab.net/gitlab/gitlabcom/issues/717226/

EXCEPTION(most recent call first)
NoMethodError: undefined method `index' for nil:NilClass
  from discussion_on_diff.rb:48:in `truncated_diff_lines'
  from grape_entity/delegator/plain_object.rb:8:in `delegate'
  from grape_entity/entity.rb:512:in `delegate_attribute'
  from grape_entity/exposure/delegator_exposure.rb:8:in `value'
  from grape_entity/exposure/represent_exposure.rb:27:in `value'
  from grape_entity/exposure/base.rb:82:in `valid_value'
  from grape_entity/exposure/base.rb:66:in `serializable_value'
  from grape_entity/exposure/nesting_exposure.rb:41:in `block in serializable_value'
  from grape_entity/exposure/nesting_exposure.rb:120:in `block (2 levels) in map_entity_exposures'
  from grape_entity/exposure/base.rb:116:in `block in with_attr_path'
  from grape_entity/options.rb:90:in `with_attr_path'
  from grape_entity/exposure/base.rb:115:in `with_attr_path'
  from grape_entity/exposure/nesting_exposure.rb:119:in `block in map_entity_exposures'
  from grape_entity/exposure/nesting_exposure.rb:118:in `each'
  from grape_entity/exposure/nesting_exposure.rb:118:in `each_with_object'
  from grape_entity/exposure/nesting_exposure.rb:118:in `map_entity_exposures'
  from grape_entity/exposure/nesting_exposure.rb:40:in `serializable_value'
  from grape_entity/entity.rb:489:in `serializable_hash'
  from active_support/core_ext/object/json.rb:142:in `block in as_json'
  from active_support/core_ext/object/json.rb:142:in `map'
  from active_support/core_ext/object/json.rb:142:in `as_json'
  from base_serializer.rb:16:in `represent'
  from issuable_actions.rb:118:in `discussions'
  from projects/merge_requests_controller.rb:214:in `discussions'
  from action_controller/metal/basic_implicit_render.rb:4:in `send_action'
  from abstract_controller/base.rb:188:in `process_action'

While the problem went away briefly, it is now back. For example https://gitlab.com/musedev/muse/merge_requests/200

And again... https://gitlab.com/musedev/muse/merge_requests/207

Is there any diagnosis here? Any way we can avoid this breakage or long-term server-side solution?

mentioned in issue gitlab-org/quality/triage-ops#160 (closed)

added [deprecated] Accepting merge requests label

removed [deprecated] Accepting merge requests label

Merge request comments have once again stopped appearing (https://gitlab.com/musedev/muse/merge_requests/307).

@andr3 think this one's more on the devopscreate side. You mind taking a look?

added devopscreate typebug labels and removed Plan [DEPRECATED] devopsplan labels

Setting groupsource code based on merge requests.

added groupsource code label

Thanks, @donaldcook! It sure does.

@tommd could you please provide access to @DouweM and myself (@andr3) to the project that has https://gitlab.com/musedev/muse/merge_requests/307 so we can investigate a bit further?

@DouweM does this ring any bell?

@andr3 It looks like the issue is indeed the one identified in https://gitlab.com/gitlab-org/gitlab-ce/issues/61159#note_165749266, with the most recent Sentry event being https://sentry.gitlab.net/gitlab/gitlabcom/issues/857479/. The error was supposedly fixed in https://gitlab.com/gitlab-org/gitlab-ce/issues/53678, but appears to have been reintroduced at some point (or we're talking about a different root cause here).

The underlying issue appears to be that the diff_line (diff metadata) for certain discussions cannot be found in the repository; if the comments were made by a bot, it's possible that their diff position (pointer at a specific section of the diff) is invalid. There's supposed to be validation in place to prevent a discussion like that from being created in the first place, but we also saw in https://gitlab.com/gitlab-org/gitlab-ce/issues/60262 that this validation is currently lacking. And of course, the page shouldn't crash even if someone does manage to create a discussion with an invalid diff pointer.

@tommd As @andr3 indicated, it would help to have access to https://gitlab.com/musedev/muse/merge_requests/307 so that we can dig into the comments in question a bit more!

marked this issue as related to #60262 (moved)

marked this issue as related to #53678 (closed)

@andr3 @DouweM You have guess access through the 10th. Let me know if there's more I can do on my end.

@tommd As a guest, we don't have access to merge requests, unfortunately 😬 Would it be possible to grant us Developer access?

Upgraded.

Hey! 👋

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue