Skip to content

GitLab Next

GitLab FOSS
GitLab FOSS
Closed (moved)
Opened by Emanuele Aina@emmh

Port Merge Request Reviews from GitLab EE to GitLab CE

Problem to solve

Reviewing merge requests currently triggers an email for each comment. This has a few drawbacks:

  • as a reviewer, I often comment on something which is not clear only to find the reason a few lines below, which prompts me to amend/drop my initial comment and I would like to be able to do so without generating useless noise for the MR author
  • as a reviewer, in some cases I have to interrupt a review midway and there's no way to tell the MR author that I haven't actually finished it
  • if there are many small comments, the MR author receives an annoying stream of emails where context is lost soon and the only sensible solution is to ignore their contents, treat them as a single "you have comments" notification and look at the GitLab web UI

This has been nicely solved by the Merge Request Review functionality introduced in GitLab 11.4, see gitlab-org/gitlab-ee#1984

Intended users

  • Documentation writers often receive many small review comments highlighting typos that are not worth an email each
  • Developers need a way to be able to amend their review progressively while they figure out the code flow without annoying the MR author in the process

Further details

gitlab-org/gitlab-ee#1984

Proposal

Can the GitLab EE Review Merge Request functionality be released as part of GitLab CE as well? Thanks! :)

Links / references

Edited by Emanuele Aina