Fix the following style-lint errors and warnings for `app/assets/stylesheets/framework/buttons.scss`
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/framework/buttons.scss
69:5 ⚠ "> .icon" and "> .icon (app/assets/stylesheets/framework/buttons.scss -59:5)" have the same properties. stylelint-gitlab/duplicate-selectors
384:1 ⚠ ".clone-dropdown-btn a" and "&.btn-icon (app/assets/stylesheets/framework/buttons.scss -221:3)" have the same properties. stylelint-gitlab/duplicate-selectors
446:3 ⚠ "&.btn-secondary-hover-link, &.btn-default-hover-link" and "i (app/assets/stylesheets/framework/buttons.scss -375:3)" stylelint-gitlab/duplicate-selectors have the same properties.
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
- Double check if all the warning have been fixed by running
yarn run stylelint-file app/assets/stylesheets/framework/buttons.scss - In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup