Disable inaccessible navigation links upon archiving a project

Summary

If a project is archived, you cannot access some pages like "Settings -> CI/CD" or "Settings -> Operations" which sounds reasonable but you will get a 404 if you try to access these sites.

One should either remove links to this sites from the menu or show a better explenation why one cannot access this site instead of a generic 404 error.

Steps to reproduce

Create project on GitLab.com, archive it and try to access "Settings -> CI/CD".

What is the current bug behavior?

Links to disabled sites are shown and will return generic 404 errors.

What is the expected correct behavior?

Links to disabled sites should be hidden or return a customized error message.

Relevant logs and/or screenshots

SKIP

Output of checks

This bug also happens on GitLab.com

Possible fixes

I would recommend to hide the menu entries for archived projects. Simply check if project is archived in app/views/layouts/nav/sidebar/_project.html.haml.

Edited by Mark Fletcher