Follow-up from "Fixes for Auto DevOps QA specs"
The following discussions from !25275 (merged) should be addressed:
-
@mlapierre started a discussion: Did you separate the check so that we get better feedback about where the test fails? If so, what do you think about changing
successful?
so that it raises an exception if any of the checks fails? And then we can stick with just usingbe_successful
in the tests, so we don't have to remember to call the other ones first. Something like:def successful?(timeout: 60) raise "Timed out waiting for the build trace to load" unless loaded? raise "Timed out waiting for the status to be a valid completed state" unless completed?(timeout: timeout) status_badge == PASSED_STATUS end
-
@mlapierre started a discussion: It looks like this method isn't used anywhere anymore. Would you mind removing it and the
loading_animation
element?