Diff file headers on 'Compare' not quite right
Summary
The file headers on the compare page are not sticking properly. Demo shown in screenshot section.
Possibly introduced here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24103/diffs
Steps to reproduce
- Navigate to a project gitlab-ce
- Click Repository -> Compare
- Select two branches with at least a full screen height's worth of diffs
- Scroll down
- Observe the file headers are not sticking properly
What is the current bug behavior?
Sticky file headers partially disappear between line change statistics
What is the expected correct behavior?
file header should only be sticky to the top
Relevant logs and/or screenshots
Screen_Recording_2019-01-28_at_9.45.53_AM
This one is much worse (Not sure why it's different): Screen_Recording_2019-01-29_at_10.26.23_PM
Possible fixes
Should be a relatively small CSS fix in diff.scss, similar to how we are changing the top position when we are on the commit page. This would also include adding a class to the file-header component, like .is-compare
Edited by Sam Bigelow