Review app links are not correct for deploying/pending manual tasks

Problem to solve

Coming from https://gitlab.com/gitlab-org/gitlab-ce/issues/53578#note_116690688:

  • Deploying to review-docs/fix-tags-for-envs
  • Failed to deploy to review/fix-tags-for-envs "Deploying to review-docs/fix-tags-for-envs" is a manual job, that does not happen until user triggers the job, however, we state it as "Deploying".

Screenshot_from_2018-11-13_11-06-57

Also, gitlab-com/www-gitlab-com!20981 (merged):

  • Staging deployment (which is a manual task that has not yet happened) shows it will deploy so it seems to understand that at least in this case, but also shows the view app link which doesn't make sense if it hasn't deployed yet.

image

Proposal

Do not show the view app link yet for a deployment that is still pending or in progress. Do not show "Deploying" status for manual items that are not yet deploying.

What does success look like, and how can we measure that?

We do no longer show confusing messages to the user

Links / references

Edited by Jason Yavorsky