Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Issues
  • #53390

Closed (promoted)
Open
Opened Oct 31, 2018 by Brian Wald@brianwaldDeveloper

Provide Visual Review tools in Review App

Problem to solve

Because review apps are single-use dynamic environments, it presents the possibility of injecting some code into the application that helps with the review process.

During the review app job, one could inject a web component (potentially taking advantage of shadow DOM) into the application, which will not affect the application functionality but provide a simple tool for reviewing and posting back comments to the merge request that automatically collect the URL that was being accessed and take a screenshot.

Example Concept

Further details

Use Cases:

  1. Developer/QA manually ADHOC testing the application for visual/presentation issues
  2. Compliance needs to document changes with screenshots, they can easily add them to the comments of the MR for an audit trail.

Proposal

image

image

In Scope

  • Take a screenshot of an area of the screen
  • Add that screenshot and a discussion comment to the Merge Request for this review app

Out of Scope / Nice to haves

  • Image annotations

  • Keyboard shortcut for Visual Review Tool

  • Keyboard shortcut / button for "capture the visible area image

  • Porting the "which pages have changed" widget into the Visual Review Tool

Similar Products

  • Marker.io who has support for GitLab issues as a destination
  • Teampaper Snap
  • Usersnap

Links / references

Edited Mar 08, 2019 by Brendan O'Leary 🐢
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/gitlab-foss#53390