Skip to content

System hook is called twice instead of once

Summary

When pushing a new tag, two tag_push events are sent to the hook instead of just one

Steps to reproduce

  • Configure a GitLab system hook with Push events
  • Create a dummy repository with a file
  • Create a new tag

What is the current bug behavior?

The hook is called twice with two slightly different payloads (http://www.mergely.com/pNL6wUWT/)

What is the expected correct behavior?

The hook should be called only once

Relevant logs and/or screenshots

http://www.mergely.com/pNL6wUWT/

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:
Current User:	root
Using RVM:	no
Ruby Version:	2.4.4p296
Gem Version:	2.6.14.1
Bundler Version:1.16.5
Rake Version:	12.3.1
Redis Version:	3.0.6
Git Version:	2.19.0
Sidekiq Version:5.1.3
Go Version:	unknown


GitLab information
Version:	11.3.0
Revision:	17bd59ad
Directory:	/home/git/gitlab
DB Adapter:	postgresql
URL:		http://localhost:10080
HTTP Clone URL:	http://localhost:10080/some-group/some-project.git
SSH Clone URL:	ssh://git@localhost:10022/some-group/some-project.git
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: oauth2_generic


GitLab Shell
Version:	8.3.3
Repository storage paths:
default: 	/home/git/data/repositories
Hooks:		/home/git/gitlab-shell/hooks
Git:		/usr/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Warning
You are running as user root, we hope you know what you are doing.
Things may work/fail for the wrong reasons.
For correct results you should run this as user git.
Checking GitLab Shell ...


GitLab Shell version >= 8.3.3 ? ... OK (8.3.3)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
1/1 ... ok
Running /home/git/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


Access to /home/git/.ssh/authorized_keys: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Sidekiq ...


Running? ... no
Try fixing it:
sudo -u git -H RAILS_ENV=production bin/background_jobs start
For more information see:
doc/install/installation.md in section "Install Init Script"
see log/sidekiq.log for possible errors
Please fix the error above and rerun the checks.


Checking Sidekiq ... Finished


Reply by email is disabled in config/gitlab.yml
Checking LDAP ...


LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab ...


Git configured correctly? ... no
Trying to fix error automatically. ...Failed
Try fixing it:
sudo -u git -H "/usr/bin/git" config --global core.autocrlf "input"
For more information see:
doc/install/installation.md in section "GitLab"
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet)
Init script exists? ... yes
Init script up-to-date? ... yes
Projects have namespace: ...
1/1 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.5 ? ... yes (2.4.4)
Git version >= 2.9.5 ? ... yes (2.19.0)
Git user has default SSH configuration? ... yes
Active users: ... 2


Checking GitLab ... Finished