Settings are not auto-expanded in GitLab 11.0+ when searching over them with `Ctrl+F`

Summary

In previous versions of GitLab (till 10.8.x) sub-sections of any Settings page in GitLab UI were auto-expanded when one searched over them. In 11.0 it stopped working. It was clarified that we moved settings to sub-sections because rendering one form with 100+ settings is not convenient, but there should be some way to search for all the settings in UI.

Steps to reproduce

  • Go to Admin Area > Setting or project-specific settings page
  • press Ctrl+F and try to search for some settings

What is the current behavior?

Sub-sections of the Settings page are not auto-expanded

What is the expected behavior?

Sub-sections of the Settings page should be auto-expanded, see the attached gif captured on GitLab 10.8.4: admin_settings_10.8.4

Results of GitLab environment info

Expand for output related to GitLab environment info

sudo gitlab-rake gitlab:env:info

System information System: Debian 8.10 Proxy: no Current User: git Using RVM: no Ruby Version: 2.4.4p296 Gem Version: 2.7.6 Bundler Version:1.16.2 Rake Version: 12.3.1 Redis Version: 3.2.11 Git Version: 2.18.0 Sidekiq Version:5.1.3 Go Version: unknown

GitLab information Version: 11.3.0-ee Revision: 4e822ac Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql DB Version: 9.6.8 URL: https://gitlabhostname.tld HTTP Clone URL: https://gitlabhostname.tld/some-group/some-project.git SSH Clone URL: git@gitlabhostname.tld:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: yes Using Omniauth: yes Omniauth Providers: google_oauth2

GitLab Shell Version: 8.3.3 Repository storage paths:

  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

sudo gitlab-rake gitlab:check SANITIZE=true

Checking GitLab Shell ...

GitLab Shell version >= 8.3.3 ? ... OK (8.3.3) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 1/13 ... ok 1/15 ... ok 1/17 ... ok 1/19 ... ok 8/28 ... ok 1/33 ... ok 1/38 ... ok 1/42 ... ok 1/44 ... repository is empty 1/45 ... repository is empty 15/47 ... ok 1/48 ... ok 15/49 ... ok 1/50 ... ok 1/51 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK

Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Reply by email ... ... Init.d configured correctly? ... skipped MailRoom running? ... skipped

Checking Reply by email ... Finished

Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 1/13 ... yes 1/15 ... yes 1/17 ... yes 1/19 ... yes 8/28 ... yes 1/33 ... yes 1/38 ... yes 1/42 ... yes 1/44 ... yes 1/45 ... yes 15/47 ... yes 1/48 ... yes 15/49 ... yes 1/50 ... yes 1/51 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.4) Git version >= 2.9.5 ? ... yes (2.18.0) Git user has default SSH configuration? ... yes Active users: ... 8 Elasticsearch version 5.1 - 5.5? ... skipped (elasticsearch is disabled)

Checking GitLab ... Finished