Remove stage/unstage icon buttons from IDE
Follow up to https://gitlab.com/gitlab-org/gitlab-ce/issues/48182
In https://gitlab.com/gitlab-org/gitlab-ce/issues/46122 we moved the discard button into a drop down to prevent the bad situation where a delete button without a confirmation could be clicked while aiming for the stage button. It wasn't perfect and created a range of other problems.
We tried to address this in https://gitlab.com/gitlab-org/gitlab-ce/issues/48182 by moving the Stage
and Discard
buttons into a permanently visible location at the top right. This is great!
But we didn't remove the stage/unstage buttons from the file list. Worse still we reverted the fix that protected users from deleting work with a misclick.
Proposal
- Remove the stage and discard buttons from the Unstaged changes list.
- Remove the unstage button from the Staged changes list.
To put it simply, the file list should have no hover action buttons.