Remove Sidekiq Limit fetch
It does not work properly anyway, see https://gitlab.com/gitlab-org/gitlab-ce/issues/36253
Moreover, it blocks the work on https://gitlab.com/gitlab-org/gitlab-ee/issues/7279
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Valery Sizov added workflowin dev label
added workflowin dev label
- Valery Sizov added 1 deleted label
added 1 deleted label
- Author Contributor
cc @victorwu
UPDATE: It's about removing https://docs.gitlab.com/ee/administration/operations/sidekiq_job_throttling.html
Edited by Valery Sizov Hi @vsizov . If it's Geo, that would go to @akaemmerle . Thanks!
- Valery Sizov mentioned in merge request !21748 (merged)
mentioned in merge request !21748 (merged)
- Author Contributor
It's not really Geo, it's just the thing that blocks the Geo team now
- Author Contributor
- Author Contributor
@akaemmerle @victorwu Not sure who is responsible for this but do you have any comments before I send my MR to review?
- Contributor
@vsizov Sorry for the late reply. Related MR changes are looking good to me! Could we have a last engineering review on this?
Edited by Andreas Kämmerle 1 - Valery Sizov added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Maintainer
It does not work properly anyway, see https://gitlab.com/gitlab-org/gitlab-ce/issues/36253
That issue was apparently resolved, and it wasn't related to having the setting enabled.
We need to remove this feature in order to fix Sidekiq more generally, and I don't want to slow down progress, but if the feature works, there may be customers using it.
Should we announce in the next release post that it will be removed, add a deprecation warning on the setting UI, and then remove it in the following release? I don't think we need to wait for a major release for something this minor, but at least one deprecation release might avoid some rollbacks and complaints. Thoughts?
- Maintainer
I found issue where we discovered the throttling factor doesn't work quite as expected, but it sounds like it's still usable in that issue as well: https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/759
Is that accurate @yorickpeterse?
If we have proof that it is broken, we can remove it immediately without consequence.
- Contributor
@mkozono Apart from the different in cache hits/misses (which from the above seems to be unrelated), it isn't really broken in that it doesn't work. Instead, we just found it to not be useful for GitLab.com in the end, and we haven't used it since. I don't think we should keep it around if we're not going to use it ourselves.
1 Yeah, we don't use it, and it leads to unusually high Redis cache misses (https://gitlab.com/gitlab-org/gitlab-ce/issues/36253#note_38464971). I don't know of any customers using it, and I haven't seen any support tickets from anyone asking how to use it.
Edited by Stan Hu 1- Achilleas Pipinellis added deprecation release post item labels
added deprecation release post item labels
- Maintainer
Hi @vsizov,
This issue is labelled ~Geo without specifying a category.
Please add any of these Geo category labels:
- ~"Geo Validation/Accuracy"
- ~"Geo Replication/Sync"
- ~"Geo Performance"
- Geo Administration
- Valery Sizov closed via merge request !21748 (merged)
closed via merge request !21748 (merged)
- Valery Sizov mentioned in commit 765686f2
mentioned in commit 765686f2
- Valery Sizov added 1 deleted label
added 1 deleted label
- Developer
@akaemmerle I added the deprecation and release post item labels, so it should be added to the release post deprecations section!
1 - 🤖 GitLab Bot 🤖 added devopssystems groupgeo labels
added devopssystems groupgeo labels
- Rachel Nienaber removed 1 deleted label
removed 1 deleted label
- Rachel Nienaber added bugperformance label and removed 1 deleted label
added bugperformance label and removed 1 deleted label
- David Fernandez mentioned in issue gitlab#208193 (closed)
mentioned in issue gitlab#208193 (closed)
- Sean McGivern mentioned in issue gitlab-com/gl-infra/scalability#638
mentioned in issue gitlab-com/gl-infra/scalability#638