ImportCommonMetrics migration fails when upgrading
The ImportCommonMetrics
migration failed while deploying RC5 to staging with the following error:
deploy-01-sv-gstg.c.gitlab-staging-1.internal == 20180831164910 ImportCommonMetrics: migrating ==============================
deploy-01-sv-gstg.c.gitlab-staging-1.internal rake aborted!
deploy-01-sv-gstg.c.gitlab-staging-1.internal StandardError: An error has occurred, this and all later migrations canceled:
deploy-01-sv-gstg.c.gitlab-staging-1.internal
deploy-01-sv-gstg.c.gitlab-staging-1.internal unknown attribute 'identifier' for Importers::PrometheusMetric.
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:90:in `find_or_build_metric!'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:44:in `block in execute'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:83:in `process_metric_query'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:73:in `block in process_metric'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:72:in `map'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:72:in `process_metric'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:63:in `block in process_group'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:62:in `map'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:62:in `process_group'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:53:in `block in process_content'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:52:in `map'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:52:in `process_content'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/importers/common_metrics_importer.rb:43:in `execute'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/service/gitlab-rails/db/migrate/20180831164910_import_common_metrics.rb:11:in `up'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/bin/bundle:23:in `load'
deploy-01-sv-gstg.c.gitlab-staging-1.internal /opt/gitlab/embedded/bin/bundle:23:in `<main>'
deploy-01-sv-gstg.c.gitlab-staging-1.internal
The migration was introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21459