Make a Rubocop cop to prefer class_methods over ClassMethods for ActiveSupport::Concern
Our code is sometimes using class_methods
and sometimes ClassMethods
. I think we should prefer class_methods
over ClassMethods
because it's less magical. It's a method, we'll know something is going to happen. It's not the case when we're merely defining a module
See: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21276#note_95108296