Invalid link for "Cycle Analytics" in help

Summary

The Cycle Analytics link at /help points to an invalid address.

Steps to reproduce

Go to https://gitlab.com/help (for EE) or https://gitlab.sauerburger.com/help (for CE) and click on GitLab Cycle Analytics.

What is the current bug behavior?

The Cycle Analytics link points to user/project/cycle_analytics.md which is resolved to /user/project/cycle_analytics.md (unless you are at /help/ instead of /help).

What is the expected correct behavior?

The Cycle Analytics link should point to /help/user/project/cycle_analytics.md like all the other links on the same page.

Output of checks

This bug happens on GitLab.com and on my CE instance. The information below is from my instance.

Results of GitLab environment info

Expand for output related to GitLab environment info
System information
System:		
Current User:	git
Using RVM:	no
Ruby Version:	2.4.4p296
Gem Version:	2.7.6
Bundler Version:1.16.2
Rake Version:	12.3.1
Redis Version:	3.2.11
Git Version:	2.17.1
Sidekiq Version:5.1.3
Go Version:	unknown

GitLab information Version: 11.1.2 Revision: 35936b0 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.sauerburger.com HTTP Clone URL: https://gitlab.sauerburger.com/some-group/some-project.git SSH Clone URL: git@gitlab.sauerburger.com:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: github, gitlab

GitLab Shell Version: 7.1.4 Repository storage paths: default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check
Checking GitLab Shell ...

GitLab Shell version >= 7.1.4 ? ... OK (7.1.4) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 2/1 ... ok 2/2 ... ok 2/3 ... ok 4/4 ... ok 2/5 ... ok 2/6 ... ok 2/9 ... ok 18/10 ... ok 2/11 ... ok 2/12 ... ok 2/13 ... ok 18/14 ... ok 18/15 ... ok 2/17 ... ok 2/18 ... ok 6/20 ... ok 2/21 ... ok 2/23 ... ok 10/25 ... ok 2/26 ... ok 10/27 ... ok 10/28 ... ok 6/29 ... ok 15/30 ... ok 6/31 ... ok 2/32 ... ok 2/33 ... ok 15/35 ... ok 2/36 ... ok 14/38 ... ok 18/39 ... ok 2/40 ... ok 2/41 ... ok 2/42 ... ok 18/43 ... ok 2/44 ... ok 18/45 ... ok 18/46 ... ok 15/47 ... ok 15/48 ... ok 18/49 ... ok 18/51 ... ok 15/52 ... ok 18/53 ... ok 2/54 ... ok 18/55 ... ok 2/56 ... ok 18/57 ... ok 2/58 ... ok 18/59 ... ok 18/60 ... ok 2/61 ... ok 3/62 ... ok 2/63 ... ok 2/64 ... ok 19/65 ... repository is empty 2/66 ... ok 2/67 ... repository is empty 2/68 ... ok 2/69 ... ok 2/70 ... ok 2/71 ... ok 2/72 ... ok 2/73 ... repository is empty 2/74 ... ok 2/75 ... ok 2/76 ... ok 2/77 ... ok 2/78 ... repository is empty 2/79 ... repository is empty 2/80 ... ok 19/81 ... repository is empty 2/82 ... ok 2/83 ... repository is empty 2/84 ... ok 2/85 ... ok 2/86 ... ok 2/87 ... ok 3/88 ... ok 2/89 ... ok 2/90 ... ok 2/91 ... ok 2/92 ... ok 2/93 ... ok 2/94 ... ok 2/95 ... ok 2/96 ... ok 2/97 ... ok 2/98 ... ok 2/99 ... ok 2/100 ... ok 2/101 ... ok 2/103 ... ok 2/104 ... ok 2/105 ... ok 3/107 ... ok 3/108 ... ok 2/109 ... ok 2/110 ... repository is empty 2/111 ... ok 2/112 ... ok 3/113 ... ok 2/114 ... ok 2/115 ... ok 2/116 ... ok 2/117 ... repository is empty 2/118 ... ok 2/119 ... ok 42/120 ... ok 2/121 ... ok 2/122 ... ok 2/123 ... repository is empty 2/124 ... ok 2/125 ... ok 2/126 ... ok 2/128 ... ok 2/129 ... repository is empty 2/130 ... ok 2/133 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK

Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Reply by email is disabled in config/gitlab.yml Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 2/1 ... yes 2/2 ... yes 2/3 ... yes 4/4 ... yes 2/5 ... yes 2/6 ... yes 2/9 ... yes 18/10 ... yes 2/11 ... yes 2/12 ... yes 2/13 ... yes 18/14 ... yes 18/15 ... yes 2/17 ... yes 2/18 ... yes 6/20 ... yes 2/21 ... yes 2/23 ... yes 10/25 ... yes 2/26 ... yes 10/27 ... yes 10/28 ... yes 6/29 ... yes 15/30 ... yes 6/31 ... yes 2/32 ... yes 2/33 ... yes 15/35 ... yes 2/36 ... yes 14/38 ... yes 18/39 ... yes 2/40 ... yes 2/41 ... yes 2/42 ... yes 18/43 ... yes 2/44 ... yes 18/45 ... yes 18/46 ... yes 15/47 ... yes 15/48 ... yes 18/49 ... yes 18/51 ... yes 15/52 ... yes 18/53 ... yes 2/54 ... yes 18/55 ... yes 2/56 ... yes 18/57 ... yes 2/58 ... yes 18/59 ... yes 18/60 ... yes 2/61 ... yes 3/62 ... yes 2/63 ... yes 2/64 ... yes 19/65 ... yes 2/66 ... yes 2/67 ... yes 2/68 ... yes 2/69 ... yes 2/70 ... yes 2/71 ... yes 2/72 ... yes 2/73 ... yes 2/74 ... yes 2/75 ... yes 2/76 ... yes 2/77 ... yes 2/78 ... yes 2/79 ... yes 2/80 ... yes 19/81 ... yes 2/82 ... yes 2/83 ... yes 2/84 ... yes 2/85 ... yes 2/86 ... yes 2/87 ... yes 3/88 ... yes 2/89 ... yes 2/90 ... yes 2/91 ... yes 2/92 ... yes 2/93 ... yes 2/94 ... yes 2/95 ... yes 2/96 ... yes 2/97 ... yes 2/98 ... yes 2/99 ... yes 2/100 ... yes 2/101 ... yes 2/103 ... yes 2/104 ... yes 2/105 ... yes 3/107 ... yes 3/108 ... yes 2/109 ... yes 2/110 ... yes 2/111 ... yes 2/112 ... yes 3/113 ... yes 2/114 ... yes 2/115 ... yes 2/116 ... yes 2/117 ... yes 2/118 ... yes 2/119 ... yes 42/120 ... yes 2/121 ... yes 2/122 ... yes 2/123 ... yes 2/124 ... yes 2/125 ... yes 2/126 ... yes 2/128 ... yes 2/129 ... yes 2/130 ... yes 2/133 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.4) Git version >= 2.9.5 ? ... yes (2.17.1) Git user has default SSH configuration? ... yes Active users: ... 15

Checking GitLab ... Finished

Possible fixes

All other the links on the same page use a similar relative path in Markdown, however, they are rendered correctly. The issue seems to be caused by the external link on the same line. I was able to fix the link by adding a single line break, see !20895 (merged).

In the long run, this should probably be investigated in order to fix the markdown renderer and prevent the issue in the future.

Edited by Frank Sauerburger