Project mirroring breaks with a colon in the password
Summary
The mirroring to a remote repository fails if the password contains a colon.
It has worked before, it was still working for an older repository of mine (before I update my github password).
I noticed this bug months ago, maybe a year.
Steps to reproduce
Change your github password to contain a colon, say foo:bar
.
Go to the project's settings, "Push to a remote repository", and configure an url with user and password like this:
https://vindarel:foo:bar@github.com/vindarel/project-test.git
Validate, refresh, click the button "Update Now".
Refresh again and you'll see an error message:
remote: Invalid username or password.
fatal: Authentication failed for 'https://*****:*****@github.com/vindarel/project-foo.git/'
Besides, in the "git repository url" field, your password is truncated to the first part before the colon:
https://vindarel:foo@github.com/vindarel/project-test.git
Note foo
.
Remove the colon from your password and try again, it works.
Example Project
What is the current bug behavior?
The mirror isn't updated, we get an error message, the password in the html field is shown truncated.
What is the expected correct behavior?
A success message ("successfully updated n minutes ago"), a repository updated, a password shown entirely in the html form.
Output of checks
This bug happens on GitLab.com