Skip to content

GitLab Next

Closed
Created by Matthias Fechner@mfechnerContributor

Version 10.8.5 stops working if adding files to new installation using templates

Summary

New version 10.8.5 breaks with fresh installation. Create a new project test and adding two new files using the templates. One LICENSE file using MIT and a Dockerfile with binary template.

If you now try to access: http://192.168.0.251:10080/root/test I see the following messages in the log files:

==> production.log <==
Started GET "/root/test" for 10.0.2.2 at 2018-06-25 18:12:23 +0000
Processing by ProjectsController#show as HTML
  Parameters: {"namespace_id"=>"root", "id"=>"test"}
Read fragment views/root/test/master/838b47fcc382e3d5c17bcb55e74bdcc18d4f0d2c/application_settings/1-20180625175205346424000/false/false/en/02e46c3507cb56b4deb85155e44afda2 (0.2ms)
Completed 500 Internal Server Error in 118ms (ActiveRecord: 17.3ms)

==> production_json.log <==
{"method":"GET","path":"/root/test","format":"html","controller":"ProjectsController","action":"show","status":500,"error":"ActionView::Template::Error: can't modify frozen Hash","duration":118.99,"view":0.0,"db":17.26,"time":"2018-06-25T18:12:23.718Z","params":[{"key":"namespace_id","value":"root"},{"key":"id","value":"test"}],"remote_ip":"10.0.2.2","user_id":1,"username":"root","gitaly_calls":6}

==> production.log <==

ActionView::Template::Error (can't modify frozen Hash):
    26:         - if view_details && merge_request
    27:           = link_to commit.title, project_commit_path(project, commit.id, merge_request_iid: merge_request.iid), class: "commit-row-message item-title"
    28:         - else
    29:           = link_to_markdown_field(commit, :title, link, class: "commit-row-message item-title")
    30:         %span.commit-row-message.visible-xs-inline
    31:           &middot;
    32:           = commit.short_id
  lib/banzai/filter/sanitization_filter.rb:32:in `customize_whitelist'
  lib/banzai/filter/sanitization_filter.rb:13:in `whitelist'
  lib/banzai/pipeline/base_pipeline.rb:21:in `block (2 levels) in singleton class'
  lib/banzai/renderer.rb:108:in `render_result'
  lib/banzai/renderer.rb:139:in `block in cacheless_render'
  lib/gitlab/metrics/influx_db.rb:98:in `measure'
  lib/banzai/renderer.rb:138:in `cacheless_render'
  lib/banzai/renderer.rb:50:in `cacheless_render_field'
  lib/banzai/renderer.rb:37:in `render_field'
  lib/banzai.rb:7:in `render_field'
  app/helpers/markup_helper.rb:102:in `markdown_field'
  app/helpers/markup_helper.rb:31:in `link_to_markdown_field'
  app/views/projects/commits/_commit.html.haml:29:in `block in _app_views_projects_commits__commit_html_haml___278382883530418144_17367620800'
  app/views/projects/commits/_commit.html.haml:18:in `_app_views_projects_commits__commit_html_haml___278382883530418144_17367620800'
  app/views/shared/_commit_well.html.haml:4:in `_app_views_shared__commit_well_html_haml___2417923661739163272_17533128760'
  app/views/projects/_files.html.haml:11:in `_app_views_projects__files_html_haml___1278027334588004402_17534928620'
  app/views/projects/show.html.haml:35:in `_app_views_projects_show_html_haml___39687266399830646_17547619220'
  lib/gitlab/i18n.rb:50:in `with_locale'
  lib/gitlab/i18n.rb:56:in `with_user_locale'
  app/controllers/application_controller.rb:355:in `set_locale'
  lib/gitlab/middleware/multipart.rb:95:in `call'
  lib/gitlab/request_profiler/middleware.rb:14:in `call'
  lib/gitlab/middleware/go.rb:17:in `call'
  lib/gitlab/etag_caching/middleware.rb:11:in `call'
  lib/gitlab/middleware/read_only/controller.rb:28:in `call'
  lib/gitlab/middleware/read_only.rb:16:in `call'
  lib/gitlab/request_context.rb:18:in `call'
  lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'
  lib/gitlab/middleware/release_env.rb:10:in `call'



==> gitlab-workhorse.log <==
192.168.0.251:10080  - - [2018/06/25:18:12:23 +0000] "GET /root/test HTTP/1.1" 500 2902 "" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36" 0.135
time="2018-06-25T18:12:24Z" level=info msg="Send static file" encoding= file=/usr/local/www/gitlab/public/favicon.ico method=GET uri=/favicon.ico
192.168.0.251:10080  - - [2018/06/25:18:12:24 +0000] "GET /favicon.ico HTTP/1.1" 200 5430 "http://192.168.0.251:10080/root/test" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36" 0.000
Edited by Matthias Fechner