Improvements to group runners
Extracted from #46010 (closed)
-
Remove all use of Ci::Runner#is_shared?
throughout the code since you can now useCi::Runner#instance_type?
. To validate this is done correctly you should test what happens locally if you remove theci_runners.shared
column from the database -
Schedule a follow up issue to actually delete the ci_runners.shared
column from the database since it is redundant now that we haveci_runners.runner_type
-
Move runner routes for pause/unpause/destroy
to shared top level route so that we reduce duplication (index must remain though as this is specific for projects/groups) -
Investigate the possibility of moving show/edit
routes to shared top level. This needs UX consideration since we would lose group/project context menu on left side -
We want some test improvements to use a factory for ProjectCiCdSetting
. This was reverted in 794ac6c5 so we can try and figure out how to get it to work.
Edited by Grzegorz Bizon