Improve Code Review section in the default MR template with
Description
Following clarification of Maintainer role in the code review process I suggest to improve the MR template to point to the code review guidelines and make it clear that the validation must come from a Maintainer, even if a Reviewer already reviewed and validated the MR.
Please update in both CE and EE as I assume this is a per project setting.
If this is validated, we probably can also improve that same section if present in other MR templates in the repo. I can open an MR for that once we agree on the new version.
have:
- Conform by the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
- [ ] Has been reviewed by a UX team member
- [ ] Has been reviewed by a Frontend maintainer
- [ ] Has been reviewed by a Backend maintainer
- [ ] Has been reviewed by a Database specialist
instead of:
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
Why?
Because this place is the most obvious one when creating a MR and people may not find it necessary or think about searching for the guidelines. Having this explicitly stated there may help reducing the misunderstandings about the code review process.