Consider removing RuboCop and ESLint from `.codeclimate.yml`
As pointed out in this discussion, the codequality
job / SAST MR widget isn't blocking and is only there as a "FYI" until we have the Dismiss feature .
That means we're running RuboCop checks and ESLint twice:
- Once in the blocking
static-analysis
job - Once in the allowed-to-fail
codequality
job
Moreover, for the codequality
job we're building a custom codeclimate-rubocop
Docker image that includes the gitlab-styles
gem, and there's no real point in doing so since the static-analysis
job is already running the custom checks from the gitlab-styles
gem.
We could just remove RuboCop and ESLint from .codeclimate.yml
and also remove the need for the custom codeclimate-rubocop
Docker image.
/cc @gonzoyumo