Skip to content

Add confirmation for registry image deletion

Summary

When deleting a registry image, there is no confirmation dialog when the delete button is clicked. This can cause accidental deletion of an image.

Steps to reproduce

  1. Create docker image and push to registry
  2. Access docker registry list
  3. Click Delete button
  4. Observe item deleted without confirmation

What is the current bug behavior?

When clicking the delete button for a docker registry image, there is no longer a confirmation box requestion verification from the user before the deletion occurs.

What is the expected correct behavior?

There should be a confirmation request given to the user when the registry delete button is clicked.

image

OK cool. So, it's the same design but in two different locations.

In the first:

Screen_Shot_2019-04-30_at_6.50.10_PM

  • Tooltip copy: "Delete repository"
  • Modal copy: "You are about to delete repository [name]. Once you confirm, this repository will be permanently deleted"
  • Buttons: [Cancel][Delete]

In the second:

Screen_Shot_2019-04-30_at_6.50.35_PM

  • Tooltip copy: "Remove image"
  • Modal copy: "You are about to delete the image [name]. This will delete the image and all tags pointing to this image."
  • Buttons: [Cancel][Delete image and tags]

I'm open to changing the second button to just say 'Delete' but my concern is that the behavior is so unexpected that I want to give an extra warning that something unexpected is going to happen.

Relevant logs and/or screenshots

registry-delete

Output of checks

This bug happens on GitLab.com

Edited by Fabien Catteau