Unable to Disable Password authentication enabled for Git over HTTP(S)

Summary

Unable to uncheck checkbox: Password authentication enabled for Git over HTTP(S)

Steps to reproduce

  1. Install gitlab omnibus docker(compose)
  2. Login as root
  3. Go to Admin -> Settings -> Sign-In Restrictions
  4. Uncheck Password authentication enabled for Git over HTTP(S)
  5. Scroll down and click Save - receive positive message
  6. Reload page and checkbox is checked again

What is the current bug behavior?

When admin user tries to disable password auth for GIT http/s, Gitlab confirm settings by positive message. But when page is reloaded checkbox is checked again and settings are not applied.

What is the expected correct behavior?

Disable HTTP/S password auth for Git and allow only Personal Token.

Relevant logs and/or screenshots

LOGS: Sorry I do not know how to unhide sensitive values.

Parameters: {"utf8"=>"✓", "authenticity_token"=>"[FILTERED]", "application_setting"=>{"default_branch_protection"=>"2", "default_project_visibility"=>"0", "default_snippet_visibility"=>"0", "default_group_visibility"=>"0", "restricted_visibility_levels"=>[""], "import_sources"=>["github", "bitbucket", "gitlab", "google_code", "fogbugz", "git", "gitlab_project", "gitea"], "project_export_enabled"=>"1", "enabled_git_access_protocol"=>"", "rsa_key_restriction"=>"[FILTERED]", "dsa_key_restriction"=>"[FILTERED]", "ecdsa_key_restriction"=>"[FILTERED]", "ed25519_key_restriction"=>"[FILTERED]", "gravatar_enabled"=>"1", "default_projects_limit"=>"100000", "max_attachment_size"=>"10", "session_expire_delay"=>"10080", "user_oauth_applications"=>"1", "user_default_external"=>"0", "signup_enabled"=>"0", "send_user_confirmation_email"=>"0", "domain_whitelist_raw"=>"", "domain_blacklist_enabled"=>"0", "domain_blacklist_raw"=>"", "after_sign_up_text"=>"", "password_authentication_enabled_for_web"=>"[FILTERED]", "password_authentication_enabled_for_git"=>"[FILTERED]", "enabled_oauth_sign_in_sources"=>["azure_oauth2"], "require_two_factor_authentication"=>"0", "two_factor_grace_period"=>"48", "home_page_url"=>"", "after_sign_out_path"=>"", "sign_in_text"=>"", "help_page_text"=>"", "help_page_hide_commercial_content"=>"0", "help_page_support_url"=>"", "max_pages_size"=>"100", "auto_devops_enabled"=>"0", "shared_runners_enabled"=>"1", "shared_runners_text"=>"", "max_artifacts_size"=>"100", "default_artifacts_expire_in"=>"30 days", "metrics_enabled"=>"0", "metrics_host"=>"localhost", "metrics_port"=>"8089", "metrics_pool_size"=>"16", "metrics_timeout"=>"10", "metrics_method_call_threshold"=>"10", "metrics_sample_interval"=>"15", "metrics_packet_size"=>"1", "prometheus_metrics_enabled"=>"0", "performance_bar_enabled"=>"0", "performance_bar_allowed_group_id"=>"", "sidekiq_throttling_enabled"=>"0", "sidekiq_throttling_factor"=>"", "recaptcha_enabled"=>"0", "recaptcha_site_key"=>"[FILTERED]", "recaptcha_private_key"=>"[FILTERED]", "akismet_enabled"=>"0", "akismet_api_key"=>"[FILTERED]", "unique_ips_limit_enabled"=>"0", "unique_ips_limit_per_user"=>"10", "unique_ips_limit_time_window"=>"3600", "admin_notification_email"=>"", "sentry_enabled"=>"0", "sentry_dsn"=>"[FILTERED]", "clientside_sentry_enabled"=>"0", "clientside_sentry_dsn"=>"[FILTERED]", "hashed_storage_enabled"=>"0", "repository_storages"=>["default"], "circuitbreaker_check_interval"=>"1", "circuitbreaker_access_retries"=>"3", "circuitbreaker_storage_timeout"=>"15", "circuitbreaker_failure_count_threshold"=>"3", "circuitbreaker_failure_reset_time"=>"1800", "repository_checks_enabled"=>"1", "plantuml_enabled"=>"0", "plantuml_url"=>"", "version_check_enabled"=>"1", "usage_ping_enabled"=>"1", "email_author_in_body"=>"0", "html_emails_enabled"=>"1", "housekeeping_enabled"=>"1", "housekeeping_bitmaps_enabled"=>"1", "housekeeping_incremental_repack_period"=>"10", "housekeeping_full_repack_period"=>"50", "housekeeping_gc_period"=>"200", "gitaly_timeout_default"=>"55", "gitaly_timeout_fast"=>"10", "gitaly_timeout_medium"=>"30", "terminal_max_session_time"=>"0", "polling_interval_multiplier"=>"1.0", "authorized_keys_enabled"=>"[FILTERED]", "throttle_unauthenticated_enabled"=>"0", "throttle_unauthenticated_requests_per_period"=>"3600", "throttle_unauthenticated_period_in_seconds"=>"3600", "throttle_authenticated_api_enabled"=>"0", "throttle_authenticated_api_requests_per_period"=>"7200", "throttle_authenticated_api_period_in_seconds"=>"3600", "throttle_authenticated_web_enabled"=>"0", "throttle_authenticated_web_requests_per_period"=>"7200", "throttle_authenticated_web_period_in_seconds"=>"3600"}, "blacklist_type"=>"raw"}

Here is the checkbox image

Results of GitLab environment info

Expand for output related to GitLab environment info

System information System:
Current User: git Using RVM: no Ruby Version: 2.3.6p384 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.3.0 Redis Version: 3.2.11 Git Version: 2.14.3 Sidekiq Version:5.0.5 Go Version: unknown

GitLab information Version: 10.4.0 Revision: 128ef10 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: http://gitlab.docker HTTP Clone URL: http://gitlab.docker/some-group/some-project.git SSH Clone URL: git@gitlab.docker:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: azure_oauth2

GitLab Shell Version: 5.11.0 Repository storage paths:

  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git root@gitlab:/opt/gitlab/embedded/service/gitlab-rails/config/environments#

Results of GitLab application Check

Expand for output related to the GitLab application check

Checking GitLab Shell ...

GitLab Shell version >= 5.11.0 ? ... OK (5.11.0) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... can't check, you have no projects Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK

Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Reply by email is disabled in config/gitlab.yml Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet) Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... can't check, you have no projects Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.3.6) Git version >= 2.7.3 ? ... yes (2.14.3) Git user has default SSH configuration? ... yes Active users: ... 2

Checking GitLab ... Finished

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)