Tag ID should use monospace fonts on Registry tables

Right now the table looks unaligned because of the shifting lengths, even though its a slice of a hash.

/cc @dimitrieh

added ~2278654 UX container registry expert ~127616 labels

added featureenhancement label

Thank you @zj !

@dimitrieh No need for UX on this one, sha must always be monospaced ;)

removed UX label

added devopspackage label

changed milestone to %Awaiting further demand

This item has been automatically determined to have 4 or fewer upvotes and is, for now, being marked as awaiting further demand. If you feel this is incorrect, please comment on the issue and I'll be happy to take a look.

added [deprecated] Accepting merge requests label

added 1 deleted label and removed 1 deleted label

@joshlambert do you know if this is still an issue? Seems pretty small, maybe something we can plan for upcoming milestone?

assigned to @ClemMakesApps

mentioned in merge request !24205 (merged)

@ClemMakesApps does indeed look like it is still an issue:

The Tag field also is affected, if you are tagging by SHA (if you are doing CD, for example). Perhaps we should use monospace here as well? @ameliabauerly what do you think?

As for scheduling, it looks like you've already started work so hopefully it's lightweight.

@joshlambert which view was that second screenshot? I'm not familiar with it

@ClemMakesApps its the same view, just if you tag your containers with the SHA instead of a name. Look here for an example: https://gitlab.com/gitlab-org/build/CNG/container_registry

removed [deprecated] Accepting merge requests label

@joshlambert it looks like we don't have a way on the frontend to tell whether tag name is tagged through a SHA. I think we should make that a separate issue :)

@ClemMakesApps I'm not convinced it should be monospaced, probably not since it's primarily a name field. Let's just focus on this for now.

@joshlambert gotcha. The MR is ready now, feel free to check it out :)

@joshlambert, I saw you pinged me on the 'tagging by SHA question,' but I'm not sure I know the answer here, because I've not yet done an issue dealing with monospace.

@tauriedavis, what are the rules around when monospace should or shouldn't be used? I looked at design.gitlab.com but didn't see any documentation around this so wanted to check in. Appreciate your thoughts!

Tags, shas, and branch names are all monospaced. Probably worth creating an issue in the pajamas repo. But for this issue, both columns would be monospaced.

Thanks so much for clarifying, Taurie. I made an issue to add this documentation to design.gitlab.com

cc: @ClemMakesApps and @joshlambert

@ClemMakesApps based on this, do you want a separate issue for monospacing the tag name as well? The diff for the SHA seems pretty minimal

@joshlambert I'm not aware of how to check whether the tag name is a SHA or not a SHA.. I'll have to investigate that further

We definitely don't have a way on the frontend to check if a tag name is a SHA.

I would also like to make the case that tag names shouldn't be in monospaced because they aren't always SHAs. My understanding is that when we tag it with a SHA name, it's because we set the name to be the same as a SHA, vs it's being used to record SHA data.

SHA data should be monospaced but tag names should not be. If I named my label after a SHA value, I wouldn't expect it to monospace. I would make the case that the tag names is of similar scenarios. Wdyt @tauriedavis @ameliabauerly

FYI: I'm still learning this packaging/registry stuff, so if my basis is incorrect, please tell me :)

Tag names in https://gitlab.com/gitlab-org/gitlab-ce/tags are monospaced which is what I was basing this off of. These would be different for some reason?? Or a separate issue is needed to discuss not making tag names monospaced?

Ah good point. I guess since you can tag on the project level with whatever name you want in monospace font, that makes sense to do the same in the container level. I'll make that change then

Thanks @ClemMakesApps, appreciate the thouroughness :) Also open to an issue to discuss whether tags should or shouldn’t be monospaced. Maybe we can use the issue @ameliabauerly linked in the pajamas repo.

np, thanks for explaining! I've updated the MR linked to this issue

@ClemMakesApps if you want to work on this one, should we set %11.8?

changed milestone to %11.8

added Deliverable label

Yeah go for it. Should be merged tomorrow anyways @joshlambert

closed via merge request !24205 (merged)

mentioned in commit 1b7c04e2