Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Issues
  • #40706
Closed
Open
Created Nov 30, 2017 by Robert Speicher@rspeicherContributor

Cross-Site Scripting when editing a comment

  • Title: Cross-Site Scripting when editing a comment
  • Scope: None
  • Weakness: Cross-site Scripting (XSS) - DOM
  • Severity: Medium
  • Link: https://hackerone.com/reports/294029
  • Date: 2017-11-30 15:50:05 +0000
  • By: @sploutchy

Details: When editing a comment into a GitLab issue, its content (no matter if in markdown code or not) will be interpreted and executed.

For example, the simple comment <img src="not" onerror="alert(1)" /> can be inserted into a comment and saved without execution. When edited however, the code will be triggered.

Impact

If an admin were to edit a malicious comment of a user, the XSS would be triggered into his browser. This scenario was however not tested.

Assignee
Assign to
Time tracking