Some CreateForkNetworkMembershipsRange jobs execute repeatedly
Summary
Looking at production.log I found that some Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange
jobs were scheduled repeatedly. The start
and end
argument were always the same.
Steps to reproduce
(How one can reproduce the issue - this is very important)
Not sure
What is the current bug behavior?
Some jobs are executed again and again.
What is the expected correct behavior?
Those jobs only execute once.
Relevant logs and/or screenshots
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 2266 - 2381
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 4471 - 4618
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 994 - 1107
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 213 - 361
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 497 - 621
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 3974 - 4081
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 1108 - 1227
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 2041 - 2158
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 3420 - 3539
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 1570 - 1682
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 2159 - 2265
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 3 - 211
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 3076 - 3186
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 5083 - 5188
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 1228 - 1337
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 364 - 496
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 740 - 862
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 1922 - 2040
Gitlab::BackgroundMigration::CreateForkNetworkMembershipsRange - Creating memberships for forks: 5296 - 5401
These lines appears every about 1 minute, with exact same numbers at the end.
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
System information System: Debian 9.2 Proxy: no Current User: git Using RVM: no Ruby Version: 2.3.5p376 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.1.0 Redis Version: 3.2.5 Git Version: 2.13.6 Sidekiq Version:5.0.4 Go Version: unknown
GitLab information Version: 10.1.3-ee Revision: 7748fef Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql DB Version: 9.6.5 URL: https://git.-----.com HTTP Clone URL: https://git.-----.com/some-group/some-project.git SSH Clone URL: git@git.-----.com:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: yes Using Omniauth: no
GitLab Shell Version: 5.9.3 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Too long, but everything passed.
Possible fixes
Possibly related code: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/background_migration/create_fork_network_memberships_range.rb