Loading spinner not stop even on errors in the Issuable Templates
Summary
A loading spinner will not stop even on errors in the Issuable Templates (Issue Templates/Merge Request Templates) Web UI.
Steps to reproduce
- Add markdown files containing special characters including
#
,%
,?
,.
to.gitlab/issue_templates
(or.gitlab/merge_request_templates
) on the default branch by committing and pushing (or doing on Web UI). (Also see #40028 (closed)) - Have access to New Issue (or New Merge Request) to select any of the templates prepared as above from issuable templates.
- You'll get a loading spinner not stopped with an error message like
Something went wrong on our end.
on top.
Example Project
You can use https://gitlab.com/tnir/tnir-gitlab-test-general/issues/new to reproduce the above.
What is the current bug behavior?
The loading spinner will not stop even if AJAX error occurs. Templates are not applied with errors.
What is the expected correct behavior?
The loading spinner must stop and disappear when AJAX error occurs.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com. (as of 2017-11-10 probably 10.1.2)
Possible fixes
I will create MRs for this soon.
/label
~bug ~"project templates"