Skip to content

"Revert this merge request" modal has confusing string

Summary:

Text label is is confusing, because "these changes" can be interpreted as the the changes being reverted, not the revert itself.

Steps to reproduce:

  1. Merge a MR,
  2. Click on "Revert" button.
  3. In the modal, make sure that "Start a new merge request with these changes" is checked.
  4. Click on the modal's "Revert" button.

Expected result:

The first time I read "Start a new merge request with these changes", I thought these changes was refering to the merged changes. I believed that this would create a new Merge Request identical to the one being reverted (useful in my case because I merged it by accident).

Actual result:

As explained in the docs, leaving that checkbox enabled will "create a new merge request with the revert changes." In other words, a MR with a revert commit.

Suggestion:

Change the wording of the checkbox label to be specific. Instead of "these changes", write "the revert changes", as in the documentation.