Restoring backup database table warning should be more explicit
Summary
When restoring a backup, the warning shown before we remove all database tables should be a little more explicit, indicating that we will be removing the tables.
Steps to reproduce
After you have generated a backup with rake gitlab:backup:create
, then do a restore using rake gitlab:backup:restore BACKUP=the_backup_file_name
What is the current bug behavior?
The warning shown is currently
Before restoring the database we recommend removing all existing
tables to avoid future upgrade problems. Be aware that if you have
custom tables in the GitLab database these tables and all data will be
removed.
The we recommend removing
can imply that the user needs to take that action, deleting all the tables themselves. That is how I initially read it. Deleting the tables yourself will give you the error
rake aborted!
ActiveRecord::StatementInvalid: PG::UndefinedTable: ERROR: relation "schema_migrations" does not exist
: TRUNCATE schema_migrations
What is the expected correct behavior?
The warning text should be changed to indicate that we will be removing the tables.
Before restoring the database, we will remove all existing
tables to avoid future upgrade problems. Be aware that if you have
custom tables in the GitLab database these tables and all data will be
removed.