Follow-up 10.2 Refactor Clusters Technical debts
This is META for ~"tech debts" which instroduced at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14879(Refactor Clusters to be consisted from GcpProvider and KubernetesPlatform).
Should we have an abstract interface for a provider? It seems that we do depend on the abstract interface because. Which methods should be implemented in every provider?
Should we raise
ArgumentError
? Can we add blank lines aroundraise
?operation_id.present?
?
I wish we could use
Clusters
module inapp/workers/
too, do you think it would be possible?
cluster_platform_kubernetes
maybe?
cluster_provider_gcp
?
Comment spotted.
A lot of comments here.
@ayufan What do you think? This test fails without the validation.
Why in 10.3? Does it make sense to leave this large comment here?
Same here - why do we need to keep this comment? Maybe tech debt issue would do?
a