Performance bar appears enabled even though it won't show up
Summary
I enabled the performance bar in the application settings, (and allowed a group I am in), for a few releases already but it never showed up. The setting in the admin area now always shows as "enabled", even when I try to disable it. Are there any other steps required to make it visible?
Running 10.1.0 via omnibus.
This might be two different bugs, or maybe it's just a UI issue. I did try with different browsers (FF Nightly, and Chromium) but it doesn't seem to change anything.
Steps to reproduce
- Go to application settings in the admin panel
- Enable the Performance Bar
- Save
What is the current bug behavior?
Nothing changes.
What is the expected correct behavior?
The Performance Bar shows up at the top of the page, just like displayed in the help.
Relevant logs and/or screenshots
This is what I see in the admin panel
<label for="application_setting_performance_bar_enabled">
<input name="application_setting[performance_bar_enabled]" type="hidden" value="0">
<input type="checkbox" value="1" checked="checked" name="application_setting[performance_bar_enabled]" id="application_setting_performance_bar_enabled">
Enabled the Performance Bar
</label>
I correctly see the POSTed values on Save.
-----------------------------134473153021005517831931096833
Content-Disposition: form-data;
name="application_setting[performance_bar_enabled]"
1
-----------------------------134473153021005517831931096833
Content-Disposition: form-data;
name="application_setting[performance_bar_allowed_group_id]"
my_group
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 2.3.5p376 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.1.0 Redis Version: 3.2.5 Git Version: 2.13.5 Sidekiq Version:5.0.4 Go Version: unknownGitLab information Version: 10.1.0 Revision: 5a695c4 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.example.com HTTP Clone URL: https://gitlab.example.com/some-group/some-project.git SSH Clone URL: git@gitlab.example.com:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: phabricator
GitLab Shell Version: 5.9.3 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 5.9.3 ? ... OK (5.9.3) Repo base directory exists? default... yes
Repo storage directories are symlinks? default... no
Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ...
3/1 ... ok
46/3 ... ok
46/6 ... ok
2/7 ... ok
2/10 ... ok
17/11 ... ok
3/19 ... ok
25/21 ... ok
25/22 ... ok
2/23 ... repository is empty
24/24 ... ok
26/25 ... ok
46/26 ... ok
46/27 ... ok
2/28 ... ok 2/29 ... ok 46/30 ... ok 46/31 ... ok 2/32 ... ok 3/33 ... ok 20/34 ... ok 31/35 ... ok 46/36 ... ok 33/38 ... ok 33/39 ... ok 33/40 ... ok 33/41 ... ok 16/42 ... ok 29/43 ... ok 28/44 ... ok 18/45 ... ok 10/46 ... ok 39/51 ... ok 39/52 ... ok 41/53 ... ok 41/54 ... ok 10/55 ... ok 42/57 ... ok 42/58 ... ok 2/59 ... ok 44/61 ... ok 44/62 ... ok 44/63 ... ok 20/64 ... ok 35/66 ... ok 48/67 ... ok
48/68 ... ok 39/69 ... ok
39/70 ... ok
39/71 ... ok
18/72 ... ok
35/73 ... ok
2/74 ... ok
51/75 ... ok
51/76 ... ok
48/77 ... ok
48/78 ... ok
48/80 ... ok
48/81 ... ok
27/82 ... ok
48/83 ... ok
56/84 ... ok
57/85 ... ok
48/86 ... ok
45/87 ... ok
16/88 ... ok
11/89 ... ok
32/90 ... ok
35/91 ... ok
48/92 ... ok
29/93 ... ok
39/94 ... ok 7/95 ... repository is empty 9/96 ... ok 46/97 ... ok 35/98 ... ok 9/99 ... ok 9/100 ... ok 2/101 ... ok 26/102 ... ok 3/103 ... ok 2/104 ... ok 12/105 ... ok 48/106 ... ok 62/107 ... ok 62/108 ... ok 62/109 ... ok 62/110 ... ok 3/111 ... ok 62/112 ... ok 15/118 ... ok 31/119 ... ok 31/120 ... ok 12/121 ... ok 16/124 ... ok 16/125 ... ok 16/126 ... ok 16/127 ... repository is empty 16/128 ... ok 16/129 ... ok 68/130 ... ok 65/131 ... ok 71/132 ... ok
68/133 ... ok 11/134 ... ok
71/135 ... ok
31/136 ... ok
31/138 ... ok
31/140 ... ok
31/142 ... ok
31/144 ... ok 31/146 ... ok
31/148 ... ok 31/149 ... ok
31/150 ... ok
31/151 ... ok 64/152 ... ok
64/153 ... ok 31/154 ... ok
7/155 ... ok
32/156 ... ok
32/157 ... ok 27/158 ... ok
27/159 ... ok
47/160 ... ok
2/161 ... ok
70/162 ... ok
35/164 ... repository is empty
70/165 ... ok 64/166 ... ok
38/167 ... ok 9/168 ... ok 46/169 ... ok 64/170 ... ok 15/172 ... ok 71/173 ... ok 9/174 ... ok 2/175 ... ok 17/177 ... ok 17/178 ... ok 17/179 ... ok 17/180 ... ok 17/181 ... ok 72/182 ... ok 73/183 ... ok 17/184 ... ok 17/185 ... ok 74/186 ... ok 3/187 ... ok 3/188 ... ok 3/189 ... ok 76/190 ... ok 48/191 ... ok 3/192 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OKAccess to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successfulChecking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 3/1 ... yes
46/3 ... yes 46/6 ... yes 2/7 ... yes
2/10 ... yes 17/11 ... yes 3/19 ... yes 25/21 ... yes 25/22 ... yes 2/23 ... yes 24/24 ... yes 26/25 ... yes 46/26 ... yes 46/27 ... yes 2/28 ... yes 2/29 ... yes 46/30 ... yes 46/31 ... yes 2/32 ... yes
3/33 ... yes
20/34 ... yes
31/35 ... yes 46/36 ... yes
33/38 ... yes
33/39 ... yes 33/40 ... yes
33/41 ... yes
16/42 ... yes
29/43 ... yes
28/44 ... yes
18/45 ... yes
10/46 ... yes 39/51 ... yes
39/52 ... yes 41/53 ... yes
41/54 ... yes
10/55 ... yes 42/57 ... yes
42/58 ... yes 2/59 ... yes
44/61 ... yes 44/62 ... yes
44/63 ... yes 20/64 ... yes
35/66 ... yes
48/67 ... yes
48/68 ... yes
39/69 ... yes
39/70 ... yes
39/71 ... yes
18/72 ... yes
35/73 ... yes
2/74 ... yes
51/75 ... yes
51/76 ... yes
48/77 ... yes
48/78 ... yes
48/80 ... yes 48/81 ... yes 27/82 ... yes 48/83 ... yes 56/84 ... yes 57/85 ... yes 48/86 ... yes 45/87 ... yes 16/88 ... yes 11/89 ... yes 32/90 ... yes 35/91 ... yes 48/92 ... yes 29/93 ... yes 39/94 ... yes 7/95 ... yes 9/96 ... yes 46/97 ... yes 35/98 ... yes
9/99 ... yes
9/100 ... yes
2/101 ... yes 26/102 ... yes
3/103 ... yes
2/104 ... yes 12/105 ... yes
48/106 ... yes
62/107 ... yes
62/108 ... yes
62/109 ... yes
62/110 ... yes
3/111 ... yes 62/112 ... yes
15/118 ... yes 31/119 ... yes
31/120 ... yes
12/121 ... yes 16/124 ... yes
16/125 ... yes 16/126 ... yes
16/127 ... yes 16/128 ... yes
16/129 ... yes 68/130 ... yes
65/131 ... yes
71/132 ... yes
68/133 ... yes
11/134 ... yes
71/135 ... yes
31/136 ... yes
31/138 ... yes
31/140 ... yes
31/142 ... yes
31/144 ... yes
31/146 ... yes
31/148 ... yes
31/149 ... yes
31/150 ... yes 31/151 ... yes 64/152 ... yes 64/153 ... yes 31/154 ... yes 7/155 ... yes 32/156 ... yes 32/157 ... yes 27/158 ... yes 27/159 ... yes 47/160 ... yes 2/161 ... yes 70/162 ... yes 35/164 ... yes 70/165 ... yes 64/166 ... yes 38/167 ... yes 9/168 ... yes 46/169 ... yes
64/170 ... yes
15/172 ... yes
71/173 ... yes 9/174 ... yes
2/175 ... yes
17/177 ... yes
17/178 ... yes
17/179 ... yes 17/180 ... yes 17/181 ... yes 72/182 ... yes 73/183 ... yes 17/184 ... yes 17/185 ... yes 74/186 ... yes 3/187 ... yes 3/188 ... yes 3/189 ... yes 76/190 ... yes 48/191 ... yes 3/192 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.3 ? ... yes (2.3.5) Git version >= 2.7.3 ? ... yes (2.13.5) Git user has default SSH configuration? ... yes Active users: ... 57Checking GitLab ... Finished