"toc: false" is shown in help page
Summary
On the Help page, the "toc: false" header of the embedded/service/gitlab-rails/doc/README.md
is rendered as Markdown resulting in an out-of-place element.
Steps to reproduce
Shows up in omnibus version and gitlab.com Help pages.
What is the current bug behavior?
The "toc: false" header of the embedded/service/gitlab-rails/doc/README.md
is rendered as Markdown resulting in an out-of-place element.
What is the expected correct behavior?
Not for it to show up.
Relevant logs and/or screenshots
n/a
Output of checks
This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.3.5p376 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.0.0 Redis Version: 3.2.5 Git Version: 2.13.5 Sidekiq Version:5.0.4 Go Version: unknown
GitLab information Version: 10.0.1 Revision: 2417795 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.sund.org HTTP Clone URL: https://gitlab.sund.org/some-group/some-project.git SSH Clone URL: git@gitlab.sund.org:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 5.9.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
I changed it to 'true' and the help page showed 'true' so it appears that the Help page is just rendering the
---
toc: false
---
as Markdown. I imagine the Help page wasn't expected to have that text to begin with.