Auto test settings upon saving JIRA settings fix
Summary
The flow implemented in https://gitlab.com/gitlab-org/gitlab-ce/issues/31511 is not working for some cases. Specifically when the Jira API Url is not reachable
Steps to reproduce
- Go to the Jira integration page
- Fill in some data - make sure you fill a url that is not reachable (eg. https://test.example.com) into Jira API url (or you can fill the url in Web Url and leave Api url empty)
- Click "Test settings and save changed"
What is the current bug behavior?
The error "Something went wrong on our end" appears
What is the expected correct behavior?
The message "Test failed. Save anyway." should appear. A user still should have the possibility to save the configuration after the test fails.
Relevant logs and/or screenshots
https://sentry.gitlap.com/gitlab/gitlabcom/issues/43510/
Possible fixes
We rescue multiple exception in https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/project_services/jira_service.rb#L297 . We could add the SocketError exception to the list.
Original Description
is no longer working. In talking with @jarka , it was working prior at some point, but now we have the following:
It should be
The scope of this issue is to reimplement the requirements here: https://gitlab.com/gitlab-org/gitlab-ce/issues/31511.