Skip to content

Milestone paging broken on CE & EE. Missing entries & duplicates.

Summary

This only appears to happen, or at least with my test project, when the milestones list reaches >= 3 pages. Essentially when paging through the list, clicking a number or using "next", the milestones listed will sometimes duplicate entries that were shown on the previous page(s). In some cases I found milestones were missing entirely from the list, despite being open.

Steps to reproduce

Wacky Duplication

  1. I created a test project here: https://gitlab.com/chriseaton/test-project/milestones
  2. The milestones are pretty simply named, however there are some "properly named" milestones in there.
  3. On page 1, notice that "Shiny Amperstand & Title of Milestone" and "Normal Milestone Title" are at the bottom of the page.
  4. Go to page 2, properly, both the above named milestones are not shown.
  5. Go to page 3, the two milestones are above are listed, despite already been shown on page 1.

Milestones Missing from List

  1. Go back to the test project: https://gitlab.com/chriseaton/test-project/milestones
  2. Take note that I have created all milestones A to Z and 0 to 9 (triple characters).
  3. Look for a milestone named "RRR".
  4. Notice that milestone "RRR" does not appear anywhere on page 1, 2, or 3.
  5. Go to: %RRR in chriseaton/test-project
  6. Notice that the "RRR" milestone is present, open, and there is no reason for it to be excluded from the list.

Example Project

https://gitlab.com/chriseaton/test-project/

What is the current bug behavior?

While paging the milestones, entries are missing, and duplicate entries are shown.

What is the expected correct behavior?

Paging should work like paging should.

Relevant logs and/or screenshots

Output of checks

this bug happens on GitLab.com, and in EE (I am an EE customer).

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:		Debian 8.9
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.3.3p222
Gem Version:	2.6.6
Bundler Version:1.13.7
Rake Version:	12.0.0
Redis Version:	3.2.5
Git Version:	2.13.5
Sidekiq Version:5.0.4
Go Version:	unknown

GitLab information
Version:	9.5.1-ee
Revision:	32be8c9
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
DB Version:	9.6.3
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: google_oauth2


GitLab Shell
Version:	5.8.0
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab Shell ...

GitLab Shell version >= 5.8.0 ? ... OK (5.8.0)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
17/1 ... ok
4/2 ... ok
17/3 ... ok
2/4 ... ok
2/5 ... ok
2/6 ... ok
16/8 ... ok
15/9 ... ok
16/14 ... ok
2/15 ... ok
16/17 ... ok
13/18 ... ok
16/19 ... ok
2/20 ... ok
4/23 ... ok
16/24 ... repository is empty
2/25 ... ok
2/26 ... ok
2/30 ... ok
13/31 ... ok
15/32 ... repository is empty
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Sidekiq ...


Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Reply by email ...


Reply by email is disabled in config/gitlab.yml


Checking Reply by email ... Finished


Checking LDAP ...


LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
17/1 ... yes
4/2 ... yes
17/3 ... yes
2/4 ... yes
2/5 ... yes
2/6 ... yes
16/8 ... yes
15/9 ... yes
16/14 ... yes
2/15 ... yes
16/17 ... yes
13/18 ... yes
16/19 ... yes
2/20 ... yes
4/23 ... yes
16/24 ... yes
2/25 ... yes
2/26 ... yes
2/30 ... yes
13/31 ... yes
15/32 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.3 ? ... yes (2.3.3)
Git version >= 2.7.3 ? ... yes (2.13.5)
Active users: ... 1
Elasticsearch version 5.1 - 5.3? ... skipped (elasticsearch is disabled)


Checking GitLab ... Finished