DRY up Repo Editor HTML
The following discussions from !13432 (merged) should be addressed:
-
@fatihacet started a discussion: (+3 comments) @jschatz1 if you or @MadLittleMods changed this line only for cosmetic refactor like removing
x === 'undefined'thing, I am afraid the new code doesn't do the same thing with the previous one. Consider the following code.var oldVersion = function($visit) { return typeof $visit === 'undefined' ? true : $visit; } var newVersion= function($visit) { return $visit ? true : $visit; } // invoking the both functions with empty argument oldVersion() // will return true newVersion() // will return undefinedIf this is something we want, then it's ok. Otherwise if this change is only for cosmetic, then we may break things.
-
@fatihacet started a discussion: Minor: this naming is weird I believe. If it will toggle something it shouldn't accept a parameter, right? It should just revert the flag. Here we are setting the flag with the value we pass. Maybe
setDialogOpenorsetDialogOpenState.Just minor one, feel free to resolve if you don't agree with this.
-
@fatihacet started a discussion: (+3 comments) I assume this
__is for i18n. First time I am seeing this. Two questions- Is this something reusable?
- How did we include it and able to use it here?
I was 3 weeks off and this maybe something we start using while I am away. Correct?
-
@fatihacet commented on a discussion: (+2 comments) @jschatz1 I was actually asking using
@click.stopwithout a value is ok or not.🤔 -
@fatihacet commented on a discussion: (+2 comments) You are indeed.
💯 -
@fatihacet started a discussion: I think we should dry these two
td's because they are almost identical only a few class name changes. -
@fatihacet started a discussion: (+2 comments) this content🤔