API specs and linting failing on master
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12936 introduced failing lints and specs on master:
1) API::GroupVariables DELETE /groups/:id/variables/:key authorized user with proper permissions deletes variable
Failure/Error: expect(response).to have_http_status(204)
expected the response to have status code 204 but it was 200
# ./spec/requests/api/group_variables_spec.rb:194:in `block (5 levels) in <top (required)>'
# ./spec/requests/api/group_variables_spec.rb:191:in `block (4 levels) in <top (required)>'
# ./spec/spec_helper.rb:98:in `block (2 levels) in <top (required)>'
1) API::GroupVariables DELETE /groups/:id/variables/:key authorized user with proper permissions deletes variable
Failure/Error: expect(response).to have_http_status(204)
expected the response to have status code 204 but it was 200
# ./spec/requests/api/group_variables_spec.rb:194:in `block (5 levels) in <top (required)>'
# ./spec/requests/api/group_variables_spec.rb:191:in `block (4 levels) in <top (required)>'
# ./spec/spec_helper.rb:98:in `block (2 levels) in <top (required)>'
Offenses:
lib/api/helpers.rb:36:5: W: Lint/DuplicateMethods: Method API::Helpers#user_group is defined at both /builds/gitlab-org/gitlab-ce/lib/api/helpers.rb:28 and /builds/gitlab-org/gitlab-ce/lib/api/helpers.rb:36.
def user_group
^^^
see https://gitlab.com/gitlab-org/gitlab-ce/pipelines/10435944/failures