Lots of fs_shards_checkYYYYMMDD-NNNN-[a-z0-9]+deleted files in /var/opt/gitlab/git-data/repositories after 9.3.8 -> 9.4.0 upgrade

Summary

Lots of fs_shards_checkYYYYMMDD-NNNN-[a-z0-9]+deleted files in /var/opt/gitlab/git-data/repositories after 9.4.0 upgrade

Steps to reproduce

Upgrade from 9.3.8 to 9.4.0. 17 projects, one empty Using subgit to sync 2 subversion repos to git repos

Example Project

N/A

What is the current bug behavior?

Lots of fs_shards_checkYYYYMMDD-NNNN-[a-z0-9]+deleted files in /var/opt/gitlab/git-data/repositories directory

What is the expected correct behavior?

Only directories under /var/opt/gitlab/git-data/repositories, no errant files

Relevant logs and/or screenshots

Errant files under /var/opt/gitlab/git-data/repositories

Expand for examples of errant files

-rw-r--r-- 1 git root 2000 Jul 23 16:55 fs_shards_check20170723-32568-oqc3oq+deleted
-rw-r--r-- 1 git root 2000 Jul 23 16:59 fs_shards_check20170723-32568-r3u7f1+deleted
-rw-r--r-- 1 git root 2000 Jul 23 16:49 fs_shards_check20170723-32568-r7uois+deleted
-rw-r--r-- 1 git root 2000 Jul 23 17:01 fs_shards_check20170723-32568-wkkqvn+deleted
-rw-r--r-- 1 git root 2000 Jul 23 16:56 fs_shards_check20170723-32568-x4ij5w+deleted
-rw-r--r-- 1 git root 2000 Jul 23 17:03 fs_shards_check20170723-32568-x6ow0u+deleted
-rw-r--r-- 1 git root 2000 Jul 23 17:01 fs_shards_check20170723-32568-zzrse8+deleted
eefe3d6aa0e1a1caad471e7d830467ee  fs_shards_check20170723-32568-oqc3oq+deleted
eefe3d6aa0e1a1caad471e7d830467ee  fs_shards_check20170723-32568-r3u7f1+deleted
eefe3d6aa0e1a1caad471e7d830467ee  fs_shards_check20170723-32568-r7uois+deleted
eefe3d6aa0e1a1caad471e7d830467ee  fs_shards_check20170723-32568-wkkqvn+deleted
eefe3d6aa0e1a1caad471e7d830467ee  fs_shards_check20170723-32568-x4ij5w+deleted
eefe3d6aa0e1a1caad471e7d830467ee  fs_shards_check20170723-32568-x6ow0u+deleted
eefe3d6aa0e1a1caad471e7d830467ee  fs_shards_check20170723-32568-zzrse8+deleted

Output of checks

N/A

Results of GitLab environment info

Expand for output related to the GitLab environment info

gitlab-rake gitlab:env:info
System information
System:		Debian 9.1
Current User:	git
Using RVM:	no
Ruby Version:	2.3.3p222
Gem Version:	2.6.6
Bundler Version:1.13.7
Rake Version:	10.5.0
Redis Version:	3.2.5
Git Version:	2.13.0
Sidekiq Version:5.0.0
Go Version:	unknown
GitLab information
Version:	9.4.0
Revision:	9bbe2ac
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
Using LDAP:	no
Using Omniauth:	no
GitLab Shell
Version:	5.3.1
Repository storage paths:

• default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

Checking GitLab Shell ...
GitLab Shell version >= 5.3.1 ? ... OK (5.3.1)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
8/6 ... ok
8/7 ... ok
8/8 ... ok
8/9 ... ok
8/10 ... ok
8/11 ... ok
8/12 ... ok
8/13 ... ok
8/14 ... ok
8/15 ... ok
8/16 ... ok
8/17 ... ok
2/18 ... ok
7/19 ... ok
12/20 ... ok
12/22 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet)
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
8/6 ... yes
8/7 ... yes
8/8 ... yes
8/9 ... yes
8/10 ... yes
8/11 ... yes
8/12 ... yes
8/13 ... yes
8/14 ... yes
8/15 ... yes
8/16 ... yes
8/17 ... yes
2/18 ... yes
7/19 ... yes
12/20 ... yes
12/22 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.3 ? ... yes (2.3.3)
Git version >= 2.7.3 ? ... yes (2.13.0)
Active users: ... 12
Checking GitLab ... Finished

Possible fixes

N/A