repository.is_ancestor is being called with null arguments
Conversation: gitaly#221 (closed)
repository.is_ancestor?(ancestor_id, descendant_id)
is being called with null arguments.
This has cause two sentry errors:
- https://sentry.gitlap.com/gitlab/gitlabcom/issues/30590/
- https://sentry.gitlap.com/gitlab/gitlabcom/issues/32958/
Depending on whether the Gitaly CommitIsAncestor
migration is enabled.
Note that this is not happening on all repositories, so it may be related to certain repos.
is_ancestor?(ancestor_id, descendant_id)
Gitlab::GitalyClient.migrate(:is_ancestor) do |is_enabled|
if is_enabled
raw_repository.is_ancestor?(ancestor_id, descendant_id)
else
merge_base_commit(ancestor_id, descendant_id) == ancestor_id
end
end
end
Note how the two sentry errors occur exclusively of one another, depending on whether the migration is enabled or not.
Edited by Andrew Newdigate