Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Issues
  • #31806
Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Closed
Open
Created May 04, 2017 by Yorick Peterse@yorickpeterseContributor6 of 6 tasks completed6/6 tasks

Clean up schema for table events

From https://gitlab.com/gitlab-com/infrastructure/issues/1709 (private to GitLab employees):

  • Missing FK: project_id -> projects (11256 entries violate this rule)
  • Missing constraint: author_id NOT NULL: https://gitlab.com/gitlab-org/gitlab-ce/issues/35586

The following will be taken care of by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12463:

  • Get rid of events.data once push events data has been moved to a separate table, since it does not appear to be used for other event types
  • Missing FK: author_id -> users (8763 entries violate this rule)
  • Missing constraint: action NOT NULL
  • Remove the column events.title as it appears to always be NULL
    • Confirmed that as of July 25th, 2017 this column is always NULL

Instead of using polymorphic types we should use separate columns for the different target types (diff_note_id, discussion_note_id, etc). This allows us to re-use existing functionality instead of having to write our own foreign key related code. The number of columns added is not that great after all.

Edited Aug 09, 2017 by Yorick Peterse
Assignee
Assign to
Time tracking